refactor(rust!): rename memmap -> memory_map as like Python
#15642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
breaking rust
eitsupi
force-pushed
the
memory_map-in-rust
branch
from
f3a3280 to
963e01c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15642 +/- ##
==========================================
- Coverage 81.30% 81.30% -0.01%
==========================================
Files 1373 1373
Lines 176243 176243
Branches 2544 2544
==========================================
- Hits 143293 143286 -7
- Misses 32466 32475 +9
+ Partials 484 482 -2 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #15642 will degrade performances by 11.74%Comparing Summary
Benchmarks breakdown
|
This comment was marked as outdated.
This comment was marked as outdated.
eitsupi
force-pushed
the
memory_map-in-rust
branch
from
963e01c to
7b8c83e
Compare
ritchie46
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading an Arrow IPC file, the following warning message may appear, but it may be unclear what it means because the Rust API uses
memmapinstead ofmemory_map.polars/crates/polars-io/src/ipc/ipc_file.rs
Line 84 in 7341aee
This PR updates
memmaparguments tomemory_map